Use mktempdir shim (until bugfix is complete)
#504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The funny thing is that the Base version already does this... https://github.com/JuliaLang/julia/blob/master/base/file.jl#L581 |
|
I'm confused. The difference would be in the |
|
|
|
That's wierd, here it looks like the exception is going right through |
|
Yeah, but see JuliaLang/julia#27982 (comment). It might be a different error but the stacktrace is just wrong... Not pleasant to debug. |
|
Ok, thanks for explaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What if we use this until the LibGit stuff is sorted out? It should allow people to test changes on the CI without being bothered by the LibGit bug. Thankfully the only place (so far) that the bug manifests itself is when cleaning up temporary directories. I've tried my best not to inadvertently catch unrelated exceptions. Its kind of a hack, but its limited to test code and should only be temporary.